From 716bba545729dbb46631bf233c1023576de54926 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Wed, 11 Nov 2009 19:24:08 +1100 Subject: [PATCH] s4:ldb Change ldb_request_add_control to the normal 'for loop' pattern --- source4/lib/ldb/common/ldb_controls.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/source4/lib/ldb/common/ldb_controls.c b/source4/lib/ldb/common/ldb_controls.c index 5276ac091da..82bd34bda5f 100644 --- a/source4/lib/ldb/common/ldb_controls.c +++ b/source4/lib/ldb/common/ldb_controls.c @@ -168,12 +168,11 @@ int ldb_request_add_control(struct ldb_request *req, const char *oid, bool criti struct ldb_control **ctrls; struct ldb_control *ctrl; - for (n=0; req->controls && req->controls[n];) { + for (n=0; req->controls && req->controls[n];n++) { /* having two controls of the same OID makes no sense */ if (strcmp(oid, req->controls[n]->oid) == 0) { return LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS; } - n++; } ctrls = talloc_array(req, -- 2.11.4.GIT