From 019f11dd5b3240d05c1abe30dec3d793d6919313 Mon Sep 17 00:00:00 2001 From: =?utf8?q?G=C3=BCnther=20Deschner?= Date: Tue, 10 May 2011 15:49:05 +0200 Subject: [PATCH] s3-printing: Fix double free of cups request. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit We never free the request in our cups api usage except for here. The reason is probably htis (from the cupsDoConnect API docs): "This function sends the IPP request to the specified server, retrying and authenticating as necessary. The request is freed with ippDelete() after receiving a valid IPP response." Revert "Fix a memory leak in cups_pull_comment_location" This reverts commit fee2664dad37536b05ce8bdae3e74d45b257f632. Autobuild-User: Günther Deschner Autobuild-Date: Tue May 10 17:32:58 CEST 2011 on sn-devel-104 --- source3/printing/print_cups.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/source3/printing/print_cups.c b/source3/printing/print_cups.c index 5ef44647fd3..ea2fc1d7c49 100644 --- a/source3/printing/print_cups.c +++ b/source3/printing/print_cups.c @@ -1731,10 +1731,6 @@ bool cups_pull_comment_location(TALLOC_CTX *mem_ctx, if (response) ippDelete(response); - if (request) { - ippDelete(request); - } - if (language) cupsLangFree(language); -- 2.11.4.GIT