From e1a4d3cdd455616a9c6cb0cff543de2b5fdc2766 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Mon, 11 Jun 2012 10:35:38 +0200 Subject: [PATCH] s3: Fix Coverity ID 709049 Dereference before null check We have dereferenced fsp before. Because smb2 is only handle based, this is a bogus check. Signed-off-by: Stefan Metzmacher Autobuild-User(master): Stefan Metzmacher Autobuild-Date(master): Mon Jun 11 15:30:54 CEST 2012 on sn-devel-104 --- source3/smbd/smb2_getinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/smbd/smb2_getinfo.c b/source3/smbd/smb2_getinfo.c index 1e0f24cf757..076cc55f1a8 100644 --- a/source3/smbd/smb2_getinfo.c +++ b/source3/smbd/smb2_getinfo.c @@ -316,7 +316,7 @@ static struct tevent_req *smbd_smb2_getinfo_send(TALLOC_CTX *mem_ctx, /* We know this name is ok, it's already passed the checks. */ - } else if (fsp && fsp->fh->fd == -1) { + } else if (fsp->fh->fd == -1) { /* * This is actually a QFILEINFO on a directory * handle (returned from an NT SMB). NT5.0 seems -- 2.11.4.GIT