From cc4541def01bb29519bd1ddccde2a1e1fd32629f Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Wed, 4 Jul 2007 23:21:51 +0000 Subject: [PATCH] r23711: Refactor the actual creation of object into its own small function. Michael (cherry picked from commit 26349c0b173e8baf6fa43deb39cb2bfdb31bf18e) (This used to be commit 852570059c974bc6c06f893e4bf5e76674e4ec00) --- examples/scripts/users_and_groups/createdomobj.pl | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/examples/scripts/users_and_groups/createdomobj.pl b/examples/scripts/users_and_groups/createdomobj.pl index 4bcfb8edf3e..6568b216642 100755 --- a/examples/scripts/users_and_groups/createdomobj.pl +++ b/examples/scripts/users_and_groups/createdomobj.pl @@ -116,7 +116,7 @@ if (@ARGV) { exit 1; } -# rpc open/close functions: +# utility functions: sub open_rpc_pipe { print "opening rpc pipe\n"; @@ -129,20 +129,22 @@ sub close_rpc_pipe { close(IPC); } +sub do_create { + my $target_name = shift; + print "creating $target_type $target_name\n"; + print IPC "$rpc_cmd $target_name\n"; +} + # main: open_rpc_pipe(); if ("x$startnum" eq "x") { - my $target_name = $prefix; - print "creating $target_type $target_name\n"; - print IPC "$rpc_cmd $target_name\n"; + do_create($prefix); } else { for (my $num = 1; $num <= $num_targets; ++$num) { - my $target_name = sprintf "%s%.05d", $prefix, $startnum + $num - 1; - print "creating $target_type $target_name\n"; - print IPC "$rpc_cmd $target_name\n"; + do_create(sprintf "%s%.05d", $prefix, $startnum + $num - 1); if (($num) % 500 == 0) { printf("500 ".$target_type."s created\n"); close_rpc_pipe(); @@ -151,5 +153,6 @@ else { } } } + close_rpc_pipe(); -- 2.11.4.GIT