From c69e4746d08fb90d77cbe58b29801e25999b5774 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Thu, 8 Jan 2004 05:37:23 +0000 Subject: [PATCH] In tdb_allocate(), we would create a new record by writing a local variable 'newrec' into the tdb. This was not initialised, so valgrind warned about it. (Note: valgrind only makes sense on tdbs with 'mmap = no' in your smb.conf) Andrew Bartlett (This used to be commit c9f9d6d3171d720b4ec0ba6af8c0c8ab178cd98b) --- source3/tdb/tdb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source3/tdb/tdb.c b/source3/tdb/tdb.c index c98b0936ed0..ff707503855 100644 --- a/source3/tdb/tdb.c +++ b/source3/tdb/tdb.c @@ -853,6 +853,8 @@ static tdb_off tdb_allocate(TDB_CONTEXT *tdb, tdb_len length, tdb_off rec_ptr, last_ptr, newrec_ptr; struct list_struct newrec; + memset(&newrec, '\0', sizeof(newrec)); + if (tdb_lock(tdb, -1, F_WRLCK) == -1) return 0; -- 2.11.4.GIT