From c1fb37d7bec1dd720f3eccbd0b490b6a335ca288 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Fri, 21 Dec 2012 15:16:10 -0800 Subject: [PATCH] Recent coverity changes added directory_create_or_exist() checks to many directories. These may not be needed, but in the meantime - ensure "make test" works again by chmod'ing the created test directories from 0777 to 0755. Reviewed-By: Andrew Bartlett Signed-off-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Sat Dec 22 02:08:33 CET 2012 on sn-devel-104 --- selftest/target/Samba3.pm | 7 +++++++ selftest/target/Samba4.pm | 6 ++++++ 2 files changed, 13 insertions(+) diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm index ea2e21d6f31..adca52fdfa3 100755 --- a/selftest/target/Samba3.pm +++ b/selftest/target/Samba3.pm @@ -765,6 +765,13 @@ sub provision($$$$$$) mkdir($_, 0777) foreach(@dirs); ## + ## lockdir and piddir must be 0755 + ## + chmod 0755, $lockdir; + chmod 0755, $piddir; + + + ## ## create ro and msdfs share layout ## diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm index 5988b836425..ba375046515 100644 --- a/selftest/target/Samba4.pm +++ b/selftest/target/Samba4.pm @@ -555,6 +555,12 @@ sub provision_raw_step1($$) mkdir($_, 0777) foreach (@{$ctx->{directories}}); + ## + ## lockdir and piddir must be 0755 + ## + chmod 0755, $ctx->{lockdir}; + chmod 0755, $ctx->{piddir}; + unless (open(CONFFILE, ">$ctx->{smb_conf}")) { warn("can't open $ctx->{smb_conf}$?"); return undef; -- 2.11.4.GIT