From bd2f1604d73f05f3b2f151a81f09824c7bb99ab5 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 11 Sep 2012 16:16:37 -0700 Subject: [PATCH] Make metze happy and the code clearer :-). Ensure we know after the destructor fires we're never going to look at this again. Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Sep 12 03:00:21 CEST 2012 on sn-devel-104 --- source3/smbd/smb2_sesssetup.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/source3/smbd/smb2_sesssetup.c b/source3/smbd/smb2_sesssetup.c index 61b5519d979..2599d2a63da 100644 --- a/source3/smbd/smb2_sesssetup.c +++ b/source3/smbd/smb2_sesssetup.c @@ -446,6 +446,12 @@ struct smbd_smb2_session_setup_state { static int pp_self_ref_destructor(struct smbd_smb2_session_setup_state **pp_state) { (*pp_state)->session = NULL; + /* + * To make things clearer, ensure the pp_self_ref + * pointer is nulled out. We're never going to + * access this again. + */ + (*pp_state)->pp_self_ref = NULL; return 0; } -- 2.11.4.GIT