From b9e11bd63ee6e1f1aac8d3b8a61ef0a4734cdd98 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 1 Jun 2012 16:42:29 +0200 Subject: [PATCH] s3: Do an early return in close_remove_share_mode Without "lck" we don't have much to clean up Signed-off-by: Stefan Metzmacher --- source3/smbd/close.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/source3/smbd/close.c b/source3/smbd/close.c index d3232aae4f7..9b7e7ac7f50 100644 --- a/source3/smbd/close.c +++ b/source3/smbd/close.c @@ -361,8 +361,7 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp, if (lck == NULL) { DEBUG(0, ("close_remove_share_mode: Could not get share mode " "lock for file %s\n", fsp_str_dbg(fsp))); - status = NT_STATUS_INVALID_PARAMETER; - goto done; + return NT_STATUS_INVALID_PARAMETER; } if (fsp->write_time_forced) { -- 2.11.4.GIT