From b019248fe85025f9df0cc20484f7b5f65838dc09 Mon Sep 17 00:00:00 2001 From: Matthieu Patou Date: Sat, 28 Apr 2012 22:12:40 -0700 Subject: [PATCH] Add some debug for FOOBAR return case as they are hard to diagnose Autobuild-User: Matthieu Patou Autobuild-Date: Sun Apr 29 09:08:15 CEST 2012 on sn-devel-104 --- source4/dsdb/schema/schema_syntax.c | 3 +++ source4/libnet/libnet_vampire.c | 7 +++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/source4/dsdb/schema/schema_syntax.c b/source4/dsdb/schema/schema_syntax.c index 0a5438ba976..6d63023b1a8 100644 --- a/source4/dsdb/schema/schema_syntax.c +++ b/source4/dsdb/schema/schema_syntax.c @@ -1054,10 +1054,12 @@ static WERROR _dsdb_syntax_OID_attr_drsuapi_to_ldb(const struct dsdb_syntax_ctx const char *str; if (in->value_ctr.values[i].blob == NULL) { + DEBUG(0, ("Attribute has no value\n")); return WERR_FOOBAR; } if (in->value_ctr.values[i].blob->length != 4) { + DEBUG(0, ("Attribute has a value with 0 length\n")); return WERR_FOOBAR; } @@ -1264,6 +1266,7 @@ static WERROR _dsdb_syntax_OID_attr_ldb_to_drsuapi(const struct dsdb_syntax_ctx obj_attr = dsdb_attribute_by_lDAPDisplayName(ctx->schema, (const char *)in->values[i].data); if (!obj_attr) { + DEBUG(0, ("Unable to find attribute %s in the schema\n", (const char *)in->values[i].data)); return WERR_FOOBAR; } SIVAL(blobs[i].data, 0, obj_attr->attributeID_id); diff --git a/source4/libnet/libnet_vampire.c b/source4/libnet/libnet_vampire.c index fad80eca807..f06e4a4cb2e 100644 --- a/source4/libnet/libnet_vampire.c +++ b/source4/libnet/libnet_vampire.c @@ -788,16 +788,19 @@ NTSTATUS libnet_vampire_cb_store_chunk(void *private_data, const struct dsdb_attribute *sa; if (!linked_attributes[i].identifier) { - return NT_STATUS_FOOBAR; + DEBUG(0, ("No linked attribute identifier\n")); + return NT_STATUS_FOOBAR; } if (!linked_attributes[i].value.blob) { - return NT_STATUS_FOOBAR; + DEBUG(0, ("No linked attribute value\n")); + return NT_STATUS_FOOBAR; } sa = dsdb_attribute_by_attributeID_id(s->schema, linked_attributes[i].attid); if (!sa) { + DEBUG(0, ("Unable to find attribute via attribute id %d\n", linked_attributes[i].attid)); return NT_STATUS_FOOBAR; } -- 2.11.4.GIT