From 9cde691b87238c14b2f2f4660694d76e99892308 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Wed, 27 Jul 2011 12:04:26 +1000 Subject: [PATCH] nbt: fix WinXP S3 domain join: alignment of nbt_netlogon_response_from_pdc This fixes WinXP joining a Samba3 domain, which was broken on hosts with an even number of characters in the host name. The alignment requested in the structure was ignored because of the overall NDR_NOALIGN set on the packet. Andrew Bartlett Autobuild-User: Jeremy Allison Autobuild-Date: Thu Jul 28 00:30:26 CEST 2011 on sn-devel-104 --- librpc/idl/nbt.idl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/librpc/idl/nbt.idl b/librpc/idl/nbt.idl index cbfa9666701..ee9a64ed3e5 100644 --- a/librpc/idl/nbt.idl +++ b/librpc/idl/nbt.idl @@ -494,7 +494,7 @@ interface nbt } nbt_netlogon_query_for_pdc; /* response from pdc */ - typedef [flag(NDR_NOALIGN),public] struct { + typedef [public] struct { netlogon_command command; astring pdc_name; [flag(NDR_ALIGN2)] DATA_BLOB _pad; -- 2.11.4.GIT