From 7ae716663ad653e08d45eae5d66c55ef853b77f2 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 4 May 2012 14:07:13 +0200 Subject: [PATCH] s3: Remove an unused parameter from check_parent_access() --- source3/smbd/open.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/source3/smbd/open.c b/source3/smbd/open.c index b6e84eaec3e..543a6619e9d 100644 --- a/source3/smbd/open.c +++ b/source3/smbd/open.c @@ -207,8 +207,7 @@ NTSTATUS smbd_check_access_rights(struct connection_struct *conn, static NTSTATUS check_parent_access(struct connection_struct *conn, struct smb_filename *smb_fname, - uint32_t access_mask, - char **pp_parent_dir) + uint32_t access_mask) { NTSTATUS status; char *parent_dir = NULL; @@ -222,10 +221,6 @@ static NTSTATUS check_parent_access(struct connection_struct *conn, return NT_STATUS_NO_MEMORY; } - if (pp_parent_dir) { - *pp_parent_dir = parent_dir; - } - if (get_current_uid(conn) == (uid_t)0) { /* I'm sorry sir, I didn't know you were root... */ DEBUG(10,("check_parent_access: root override " @@ -636,8 +631,7 @@ static NTSTATUS open_file(files_struct *fsp, } else if (local_flags & O_CREAT){ status = check_parent_access(conn, smb_fname, - SEC_DIR_ADD_FILE, - NULL); + SEC_DIR_ADD_FILE); } else { /* File didn't exist and no O_CREAT. */ return NT_STATUS_OBJECT_NAME_NOT_FOUND; @@ -2554,8 +2548,7 @@ static NTSTATUS mkdir_internal(connection_struct *conn, status = check_parent_access(conn, smb_dname, - access_mask, - NULL); + access_mask); if(!NT_STATUS_IS_OK(status)) { DEBUG(5,("mkdir_internal: check_parent_access " "on directory %s for path %s returned %s\n", -- 2.11.4.GIT