From 36ec31336f4547b311148f27075cdb4fc8c37609 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 4 Sep 2012 10:36:47 +0200 Subject: [PATCH] s3: Slightly simplify open_file() The "else" is not necessary. In the if-branch we just returned. Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Wed Sep 26 18:08:03 CEST 2012 on sn-devel-104 --- source3/smbd/open.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/smbd/open.c b/source3/smbd/open.c index 1f9a372dfb6..10c855c225f 100644 --- a/source3/smbd/open.c +++ b/source3/smbd/open.c @@ -678,7 +678,8 @@ static NTSTATUS open_file(files_struct *fsp, DEBUG(3,("Permission denied opening %s\n", smb_fname_str_dbg(smb_fname))); return NT_STATUS_ACCESS_DENIED; - } else if(flags & O_CREAT) { + } + if (flags & O_CREAT) { /* We don't want to write - but we must make sure that O_CREAT doesn't create the file if we have write access into the directory. -- 2.11.4.GIT