From 1466acba7e18f5ce733b376d031f1596a1a674d8 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sun, 28 Jul 2002 06:08:30 +0000 Subject: [PATCH] good security patch from Timothy.Sell@unisys.com we could generate short passwords! samba-patches 880 --- source/lib/genrand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/lib/genrand.c b/source/lib/genrand.c index ee8bc0b1d5a..fe756169a66 100644 --- a/source/lib/genrand.c +++ b/source/lib/genrand.c @@ -259,7 +259,7 @@ char *generate_random_str(size_t len) len = sizeof(retstr) -1; generate_random_buffer( retstr, len, False); for (i = 0; i < len; i++) - retstr[i] = c_list[ retstr[i] % sizeof(c_list) ]; + retstr[i] = c_list[ retstr[i] % (sizeof(c_list)-1) ]; retstr[i] = '\0'; -- 2.11.4.GIT