| commit | d776fd807e0c9a62f428ce666ff812655f98bc47 | |
| author | Andrew Bartlett <abartlet@samba.org> | |
| Wed, 9 Jan 2013 05:59:18 +0000 (9 16:59 +1100) | ||
| committer | Karolin Seeger <kseeger@samba.org> | |
| Mon, 14 Jan 2013 18:15:45 +0000 (14 19:15 +0100) | ||
| tree | 36fe40832c70ecf9e19e5c8df6b148a278b9090d | treesnapshot (tar.gz zip) |
| parent | a75805490d96a85786287f5d0522dd7671d6816e | commitdiff |
dsdb-acl: Run sec_access_check_ds on each attribute proposed to modify (bug #9554 - CVE-2013-0172)
This seems inefficient, but is needed for correctness. The
alternative might be to have the sec_access_check_ds code confirm that
*all* of the nodes in the object tree have been cleared to
node->remaining_bits == 0.
Otherwise, I fear that write access to one attribute will become write
access to all attributes.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
This seems inefficient, but is needed for correctness. The
alternative might be to have the sec_access_check_ds code confirm that
*all* of the nodes in the object tree have been cleared to
node->remaining_bits == 0.
Otherwise, I fear that write access to one attribute will become write
access to all attributes.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
| source4/dsdb/samdb/ldb_modules/acl.c | diffblobblamehistory |