| commit | 9a0b6a2273f2b9ff58466a6a7402390dfbf512d2 | |
| author | Jeremy Allison <jra@samba.org> | |
| Tue, 3 Dec 2002 08:02:21 +0000 (3 08:02 +0000) | ||
| committer | Jeremy Allison <jra@samba.org> | |
| Tue, 3 Dec 2002 08:02:21 +0000 (3 08:02 +0000) | ||
| tree | bc49f806b3c45d1d827eb12611ef460549a7eec4 | treesnapshot (tar.gz zip) |
| parent | e21df94c52a51e57d50611e22c6dfc8017504d75 | commitdiff |
Fixed nasty bug where file writes with start offsets in the range
0x80000000 -> 0xFFFFFFFF would fail as they were being cast
from IVAL (uint32) to SMB_OFF_T (off_t or off64_t, both *signed* types).
The sign extension would cause the offset to be treated as negative.
Thanks to Herb for helping me track this one down (IRIX is good for large
file tests :-).
Jeremy.
PS. That horrid EXEXIST thing has broken configure.....
(This used to be commit fc7d3faed798e7496f2991ec7d795c3b1a3758f5)
0x80000000 -> 0xFFFFFFFF would fail as they were being cast
from IVAL (uint32) to SMB_OFF_T (off_t or off64_t, both *signed* types).
The sign extension would cause the offset to be treated as negative.
Thanks to Herb for helping me track this one down (IRIX is good for large
file tests :-).
Jeremy.
PS. That horrid EXEXIST thing has broken configure.....
(This used to be commit fc7d3faed798e7496f2991ec7d795c3b1a3758f5)
| source3/include/includes.h | diffblobblamehistory | |
| source3/smbd/blocking.c | diffblobblamehistory | |
| source3/smbd/nttrans.c | diffblobblamehistory | |
| source3/smbd/reply.c | diffblobblamehistory |