| commit | 304554115a2f2dc316386a9ea5bec237d67f595f | |
| author | Steven Danneman <steven.danneman@isilon.com> | |
| Wed, 3 Sep 2008 22:31:39 +0000 (3 15:31 -0700) | ||
| committer | Jeremy Allison <jra@samba.org> | |
| Thu, 4 Sep 2008 18:50:25 +0000 (4 11:50 -0700) | ||
| tree | 31a234031804f712e6be3608c8d094fdd20518c9 | treesnapshot (tar.gz zip) |
| parent | c16f2907c5f7a66b3e5d58af8f87ad35c5f77670 | commitdiff |
Cleanup of DC enumeration in get_dcs()
This is a fix for a few small inefficiencies/bugs in the get_dcs() path.
* because the third add_one_dc_unique() loop was outside the ADS check all DCs
returned from the non-sitename lookup were being tacked onto the dc_name_ip
list twice.
* add_one_dc_unique() now checks if the given IP address already exists before
adding it to the list, making the returned list actually unique
* added more thorough doxygen comment headers
(This used to be commit cb2d488e1dbd90953c496c5e25d648977884f7e3)
This is a fix for a few small inefficiencies/bugs in the get_dcs() path.
* because the third add_one_dc_unique() loop was outside the ADS check all DCs
returned from the non-sitename lookup were being tacked onto the dc_name_ip
list twice.
* add_one_dc_unique() now checks if the given IP address already exists before
adding it to the list, making the returned list actually unique
* added more thorough doxygen comment headers
(This used to be commit cb2d488e1dbd90953c496c5e25d648977884f7e3)
| source3/lib/util_sock.c | diffblobblamehistory | |
| source3/libsmb/conncache.c | diffblobblamehistory | |
| source3/winbindd/winbindd_cm.c | diffblobblamehistory |