From b25619175f9ed3a62210b5b9f9cda7c4cde4f0db Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 10 Jul 2012 16:50:51 -0700 Subject: [PATCH] Fix typo we've had for a long time in set_re_uid() in the USE_SETRESUID case. We only set the real euid, not the effective one. This is not a security issue as this is *only* used in the quota code, and only between code that brackets it with save_re_uid()/restore_re_uid(), Also this is not used on most platforms (we use USE_SETREUID by preference) but it's better to have this right. Bug to follow to get this fixed in 3.6.next and 3.5.next. --- source3/lib/util_sec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/lib/util_sec.c b/source3/lib/util_sec.c index 7c05f17de57..36d2a2b2538 100644 --- a/source3/lib/util_sec.c +++ b/source3/lib/util_sec.c @@ -337,7 +337,7 @@ int set_re_uid(void) uid_t uid = geteuid(); #if defined(USE_SETRESUID) || defined(USE_LINUX_THREAD_CREDENTIALS) - samba_setresuid(geteuid(), -1, -1); + samba_setresuid(uid, uid, -1); #endif #if USE_SETREUID -- 2.11.4.GIT