From 1fbc18572543ed3056057df6ec4990278726fbf4 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Wed, 25 Apr 2012 18:55:46 -0400 Subject: [PATCH] replace: Fix use of mktemp mktemp always returns the template, so checking for NULL doesn't cactch any error. Errors are reported by turning the template into an empty string. Autobuild-User: Simo Sorce Autobuild-Date: Thu Apr 26 16:14:24 CEST 2012 on sn-devel-104 --- lib/replace/replace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/replace/replace.c b/lib/replace/replace.c index c076ba1fc8b..322bf49e91b 100644 --- a/lib/replace/replace.c +++ b/lib/replace/replace.c @@ -412,8 +412,8 @@ int rep_mkstemp(char *template) { /* have a reasonable go at emulating it. Hope that the system mktemp() isn't completely hopeless */ - char *p = mktemp(template); - if (!p) + mktemp(template); + if (template[0] == 0) return -1; return open(p, O_CREAT|O_EXCL|O_RDWR, 0600); } -- 2.11.4.GIT