From 13eab02679a012b332beed28b0a4fc05cb9fd258 Mon Sep 17 00:00:00 2001 From: Karolin Seeger Date: Mon, 16 Jun 2008 15:21:28 +0200 Subject: [PATCH] winbind cache: Don't create SN cache entries during name-to-sid queries. Clients can request name-to-sid queries for different combinations of upper and lower case names. We don't want to create the reverse caching entries for each combination used. This avoids inconsistent answers on sid-to-name queries. Please review! Karolin (This used to be commit b58e4f6b3d73294d8448c0dff4341183c52e5b7c) --- source3/winbindd/winbindd_cache.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c index 60403717c18..03512b97454 100644 --- a/source3/winbindd/winbindd_cache.c +++ b/source3/winbindd/winbindd_cache.c @@ -1451,13 +1451,13 @@ do_query: if (domain->online && (NT_STATUS_IS_OK(status) || NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED))) { wcache_save_name_to_sid(domain, status, domain_name, name, sid, *type); + + /* Don't add SN cache entries for sid-to-name queries during this operation. + * It leads to inconsistent answers during sid-to-name queries as the + * client can ask for different combinations of lower case and upper case + * names in these name-to-sid queries. + */ - /* Only save the reverse mapping if this was not a UPN */ - if (!strchr(name, '@')) { - strupper_m(CONST_DISCARD(char *,domain_name)); - strlower_m(CONST_DISCARD(char *,name)); - wcache_save_sid_to_name(domain, status, sid, domain_name, name, *type); - } } return status; -- 2.11.4.GIT