| commit | fc496ef323c908a6b621198d9dc8076f6857385e | |
| author | Andrew Bartlett <abartlet@samba.org> | |
| Fri, 8 Mar 2013 05:15:37 +0000 (8 16:15 +1100) | ||
| committer | Michael Adam <obnox@samba.org> | |
| Sun, 10 Mar 2013 12:31:23 +0000 (10 13:31 +0100) | ||
| tree | 61ac897e910b9bddd3aa28dc84d6080e14baf40d | treesnapshot (tar.gz zip) |
| parent | 287b5f6c0f40d3e3d09bc2ce80f5fee02cbae40f | commitdiff |
smbd:posix_acls Remove incorrectly added lp_create_mask() and lp_dir_mask() calls
When 6adc7dad96b8c7366da042f0d93b28c1ecb092eb removed the calls to
lp_security_mask/lp_force_security_mode/lp_dir_security_mask/lp_force_dir_security_mode
these calls were replaced with lp_create_mask() and lp_dir_mask()
The issue is that while lp_security_mask() and lp_dir_security_mask defaulted to
0777, the replacement calls did not. This changes behaviour, and incorrectly
prevents a posix mode being specified by the client from being applied to
the disk in the non-ACL enabled case.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
When 6adc7dad96b8c7366da042f0d93b28c1ecb092eb removed the calls to
lp_security_mask/lp_force_security_mode/lp_dir_security_mask/lp_force_dir_security_mode
these calls were replaced with lp_create_mask() and lp_dir_mask()
The issue is that while lp_security_mask() and lp_dir_security_mask defaulted to
0777, the replacement calls did not. This changes behaviour, and incorrectly
prevents a posix mode being specified by the client from being applied to
the disk in the non-ACL enabled case.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
| source3/smbd/posix_acls.c | diffblobblamehistory |