| commit | e687a20d60144af2cb459231fb6a699f2533ce9d | |
| author | Jeremy Allison <jra@samba.org> | |
| Fri, 8 Jan 2010 18:17:46 +0000 (8 10:17 -0800) | ||
| committer | Karolin Seeger <kseeger@samba.org> | |
| Mon, 11 Jan 2010 11:12:15 +0000 (11 12:12 +0100) | ||
| tree | f151f8ff82cb9c63b71d59eab542efdbe0231467 | treesnapshot (tar.gz zip) |
| parent | ea7d2995f383e183ef4d8a21705a343581e71f4a | commitdiff |
Re-fix bug 5202 - cannot change ACLs on writable file with "dos filemode=yes"
This bug re-occurred for 3.3.x and above.
The reason is that to change a NT ACL we now have to open the file requesting
WRITE_DAC and WRITE_OWNER access. The mapping from POSIX "w" to NT permissions
in posix_acls doesn't add these bits when "dos filemode = yes", so even though
the permission or owner change would be allowed by the POSIX ACL code, the
NTCreateX call fails with ACCESS_DENIED now we always check NT permissions
first.
Added in the mapping from "w" to WRITE_DAC and WRITE_OWNER access.
Jeremy.
(cherry picked from commit d7713d11a6dc2d66c820d7496bc45eb5fe527fbf)
This bug re-occurred for 3.3.x and above.
The reason is that to change a NT ACL we now have to open the file requesting
WRITE_DAC and WRITE_OWNER access. The mapping from POSIX "w" to NT permissions
in posix_acls doesn't add these bits when "dos filemode = yes", so even though
the permission or owner change would be allowed by the POSIX ACL code, the
NTCreateX call fails with ACCESS_DENIED now we always check NT permissions
first.
Added in the mapping from "w" to WRITE_DAC and WRITE_OWNER access.
Jeremy.
(cherry picked from commit d7713d11a6dc2d66c820d7496bc45eb5fe527fbf)
| source3/smbd/posix_acls.c | diffblobblamehistory |