mount.cifs: don't leak passwords with verbose option
commit2a422f453dd3ad9978e6ec0ac40c122163c028ed
authorJeff Layton <jlayton@redhat.com>
Fri, 25 Sep 2009 11:03:07 +0000 (25 07:03 -0400)
committerKarolin Seeger <kseeger@samba.org>
Mon, 28 Sep 2009 11:24:07 +0000 (28 13:24 +0200)
tree3604279fdd72cdc83b298ae9531d03e56a12e7c2
parent42351937b00f6aa013d16c2a4dbd0b37e7e9ed11
mount.cifs: don't leak passwords with verbose option

When running mount.cifs with the --verbose option, it'll print out the
option string that it passes to the kernel...including the mount
password if there is one. Print a placeholder string instead to help
ensure that this info can't be used for nefarious purposes.

Also, the --verbose option printed the option string before it was
completely assembled anyway. This patch should also make sure that
the complete option string is printed out.

Finally, strndup passwords passed in on the command line to ensure that
they aren't shown by --verbose as well. Passwords used this way can
never be truly kept private from other users on the machine of course,
but it's simple enough to do it this way for completeness sake.

Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
Part 2/2 of a fix for CVE-2009-2948.
source3/client/mount.cifs.c