From 8a20f78483bc4a09c8c2b1452547bb5d5f52062f Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 23 Jan 2010 13:53:48 +0100 Subject: [PATCH] libcli/security: Fix a valgrind error in dom_sid_parse --- libcli/security/dom_sid.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c index 9952977fa9e..6a046cd8061 100644 --- a/libcli/security/dom_sid.c +++ b/libcli/security/dom_sid.c @@ -113,6 +113,10 @@ bool dom_sid_parse(const char *sidstr, struct dom_sid *ret) if (sidstr[i] == '-') num_sub_auths++; } + if (num_sub_auths > ARRAY_SIZE(ret->sub_auths)) { + return false; + } + ret->sid_rev_num = rev; ret->id_auth[0] = 0; ret->id_auth[1] = 0; -- 2.11.4.GIT