| commit | e042002bb5ee8974220e1ade56b64389571f75a6 | |
| author | Andrew Tridgell <tridge@samba.org> | |
| Tue, 6 Feb 2007 04:43:48 +0000 (6 04:43 +0000) | ||
| committer | Gerald (Jerry) Carter <jerry@samba.org> | |
| Wed, 10 Oct 2007 19:44:41 +0000 (10 14:44 -0500) | ||
| tree | 201ac6e9f97fb6931be31b0e2d8edae576f5e432 | treesnapshot (tar.gz zip) |
| parent | a4a394c9bb42ed1883c95c10f9c24987d4ab4294 | commitdiff |
r21171: fixed a bug related to recursive event handling.
If this happens:
- two sockets are readable, and select/epoll/aio returns both of
them
- read event on socket1 is called
- inside that read event an event_loop_once is called, this returns that
socket2 is readable
- read event on socket2 is called
- event_loop_once returns
- top level event handler then calls read event on socket2 (as it
still has that listed as readable)
- read handler for socket2 returns zero byte read, which is
interpreted as end of file
- socket is incorrectly closed
this happened with ctdb, but it could happen anywhere (just
rarely). The fix is trivial - ensure we break out of the event loop
when we have been called recursively.
If this happens:
- two sockets are readable, and select/epoll/aio returns both of
them
- read event on socket1 is called
- inside that read event an event_loop_once is called, this returns that
socket2 is readable
- read event on socket2 is called
- event_loop_once returns
- top level event handler then calls read event on socket2 (as it
still has that listed as readable)
- read handler for socket2 returns zero byte read, which is
interpreted as end of file
- socket is incorrectly closed
this happened with ctdb, but it could happen anywhere (just
rarely). The fix is trivial - ensure we break out of the event loop
when we have been called recursively.