From 81c193da0945ea2dd355590a121ec83d77a594bd Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Fri, 2 Oct 2009 22:38:58 +1000 Subject: [PATCH] Revert "s4-ldb: fixed a memory leak" This reverts commit c7358d989034c9d936c04f2a7e4f89db252b798e. --- source4/lib/ldb/ldb_tdb/ldb_index.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/source4/lib/ldb/ldb_tdb/ldb_index.c b/source4/lib/ldb/ldb_tdb/ldb_index.c index 66d70a9f47e..1acbc204f7f 100644 --- a/source4/lib/ldb/ldb_tdb/ldb_index.c +++ b/source4/lib/ldb/ldb_tdb/ldb_index.c @@ -135,7 +135,6 @@ static int ltdb_convert_from_idxptr(struct ldb_module *module, struct ldb_messag return LDB_ERR_OPERATIONS_ERROR; } - talloc_free(el->values); *el = ptr->el; if (ptr_out) { @@ -164,11 +163,7 @@ static int ltdb_update_idxptr(struct ldb_module *module, TALLOC_CTX *mem_ctx, el->values = val2; el->num_values = 1; - if (strcmp(el->name, LTDB_IDXPTR) == 0) { - abort(); - } - - el->values[0].data = talloc_memdup(val2, &ptr, sizeof(ptr)); + el->values[0].data = talloc_memdup(el->values, &ptr, sizeof(ptr)); el->values[0].length = sizeof(ptr); /* update the name */ -- 2.11.4.GIT