s3:registry: eliminate race condition in creating/scanning sorted subkeys
commita752bbd10d661ebc93b8d51bd583eb62eb00ad18
authorMichael Adam <obnox@samba.org>
Mon, 8 Feb 2010 10:01:47 +0000 (8 11:01 +0100)
committerMichael Adam <obnox@samba.org>
Fri, 12 Feb 2010 22:12:12 +0000 (12 23:12 +0100)
tree09e5e4c5883c3e08f2903448c410eb2bd3e05fa1
parent09f3ed102472304d6b4446a6fab9cf6f05c9176a
s3:registry: eliminate race condition in creating/scanning sorted subkeys

Called, from key_exists, scan_sorted_subkeys re-creates the sorted
subkeys record of the given key and then searches through it.
The race is that between creation and parsing of the sorted subkey
record, another process that stores some other subkey of the same
parent key will delete the sorted subkey record, resulting in an
WERR_BADFILE of an operation that should actually succeed.

This patch fixes the issue by wrapping the creation and parsing
into a transaction.

Michael
source3/registry/reg_backend_db.c