From 6fcb3bbdae835f513e5c539eddb437f2ae4c1c88 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 6 Jul 2011 09:37:04 +0200 Subject: [PATCH] s3: Fix Coverity ID 2586 -- NO_EFFECT tsocket_address_bsd_sockaddr returns ssize_t, and on some systems socklen_t is unsigned. So (len < 0) could never have turned true. Volker --- source3/lib/util_sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/lib/util_sock.c b/source3/lib/util_sock.c index a35bd58d11d..5154a83fecf 100644 --- a/source3/lib/util_sock.c +++ b/source3/lib/util_sock.c @@ -1135,7 +1135,7 @@ int get_remote_hostname(const struct tsocket_address *remote_address, char tmp_name[MAX_DNS_NAME_LENGTH]; struct name_addr_pair nc; struct sockaddr_storage ss; - socklen_t len; + ssize_t len; int rc; if (!lp_hostname_lookups()) { -- 2.11.4.GIT