From cb370cc28ce361628df137c9aef02739aca062db Mon Sep 17 00:00:00 2001 From: Jim McDonough Date: Wed, 15 Mar 2006 02:31:11 +0000 Subject: [PATCH] r14408: More on fix for coverity #36. The previous fix would cause us to marshall a buffer based on an unknown size. Zero out the sec_desc buffer to prevent this. This is still not getting proper results for a registry security descriptor (everything gets ACCESS DENIED), but at least we aren't blowing out memory now... --- source/libmsrpc/cac_winreg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source/libmsrpc/cac_winreg.c b/source/libmsrpc/cac_winreg.c index aa847602cc3..acd83f40760 100644 --- a/source/libmsrpc/cac_winreg.c +++ b/source/libmsrpc/cac_winreg.c @@ -831,6 +831,8 @@ int cac_RegGetKeySecurity(CacServerHandle *hnd, TALLOC_CTX *mem_ctx, struct RegG uint32 buf_size; SEC_DESC_BUF buf; + ZERO_STRUCT(buf); + if(!hnd) return CAC_FAILURE; -- 2.11.4.GIT