| commit | 5db731d899987d1a53e72f16b92b7e01eafd80c2 | |
| author | Volker Lendecke <vlendec@samba.org> | |
| Sun, 20 Jun 2004 08:37:01 +0000 (20 08:37 +0000) | ||
| committer | Gerald (Jerry) Carter <jerry@samba.org> | |
| Wed, 10 Oct 2007 15:51:59 +0000 (10 10:51 -0500) | ||
| tree | a4f1cb1d1caa48ddb26120131b9a16abbab0f346 | treesnapshot (tar.gz zip) |
| parent | ee79226d2a4486be66b47e7ff86e40f91c654ba7 | commitdiff |
r1202: This hopefully fixes our memory use when unmarshalling strings. The test case
was 'rpcclient -c "enumprinters 2"' with 4000 printers. At some point this
completely exploded in memory usage. For every string we talloc'ed memory up
to the end of the buffer. -> O(n^2).
This survives valgrind with this number of printers. It might also have
influence on winbind with a large number of users.
All those who dare to look at samba3 rpc code, could you please take a look? I
know this is a burden, but I would like comments ;-)))
Volker
(This used to be commit af251f4ea63c584604972e1c8add83e65046de80)
was 'rpcclient -c "enumprinters 2"' with 4000 printers. At some point this
completely exploded in memory usage. For every string we talloc'ed memory up
to the end of the buffer. -> O(n^2).
This survives valgrind with this number of printers. It might also have
influence on winbind with a large number of users.
All those who dare to look at samba3 rpc code, could you please take a look? I
know this is a burden, but I would like comments ;-)))
Volker
(This used to be commit af251f4ea63c584604972e1c8add83e65046de80)
| source3/rpc_parse/parse_prs.c | diffblobblamehistory |