| commit | 496802fde92a54729d08755c9562ef7fb322a375 | |
| author | Derrell Lipman <derrell.lipman@unwireduniverse.com> | |
| Fri, 24 Oct 2008 15:19:12 +0000 (24 11:19 -0400) | ||
| committer | Karolin Seeger <kseeger@samba.org> | |
| Tue, 18 Nov 2008 09:06:43 +0000 (18 10:06 +0100) | ||
| tree | 731403180ae3688cc7ccec81bf840f8ec85b6922 | treesnapshot (tar.gz zip) |
| parent | b8de18250f6314cf17d3932a5b6af03e4bf81df4 | commitdiff |
Error return is False, not -1
- There were a few places in SMBC_getatr() that returned -1 instead of a
boolean. -1 was intended to mean error, but that's what False is for, and
the usages of this function assume that it returns a boolean with False as
the error condition.
- per Jelmer's request, use false vs. False in new code, even if not making
changes globally.
Derrell
(cherry picked from commit 89e22a2c969ab7a38016d4a145feb061fa6ae108)
- There were a few places in SMBC_getatr() that returned -1 instead of a
boolean. -1 was intended to mean error, but that's what False is for, and
the usages of this function assume that it returns a boolean with False as
the error condition.
- per Jelmer's request, use false vs. False in new code, even if not making
changes globally.
Derrell
(cherry picked from commit 89e22a2c969ab7a38016d4a145feb061fa6ae108)
| source/libsmb/libsmb_file.c | diffblobblamehistory |