| commit | 5370afe8c2d9f4b77711010f2ce9ea4fc33886c4 | |
| author | Andrew Tridgell <tridge@samba.org> | |
| Thu, 19 Oct 2006 10:02:26 +0000 (19 10:02 +0000) | ||
| committer | Gerald (Jerry) Carter <jerry@samba.org> | |
| Wed, 10 Oct 2007 19:21:29 +0000 (10 14:21 -0500) | ||
| tree | 75f3698fe8f2b2eab6b018bcad9f9242c51ac095 | treesnapshot (tar.gz zip) |
| parent | c3e4b2d2782832bcb0072cd7cbb7f0f94910d4bc | commitdiff |
r19412: some rather strange looking changes to talloc that gain us about 50%
in the talloc benchmark. These changes were driven by some cachegrind
profiles, with the biggest improvements coming from inlining some
functions.
I don't think it would be a good idea to start spreading inline and
likely()/unlikely() in other parts of Samba, as the benefit in most
code will be very small, but talloc() is such a speed critical part of
Samba that I think these changes are worthwhile
(This used to be commit 8644708c3f42d249b5d1fd2bde37aeb35288da13)
in the talloc benchmark. These changes were driven by some cachegrind
profiles, with the biggest improvements coming from inlining some
functions.
I don't think it would be a good idea to start spreading inline and
likely()/unlikely() in other parts of Samba, as the benefit in most
code will be very small, but talloc() is such a speed critical part of
Samba that I think these changes are worthwhile
(This used to be commit 8644708c3f42d249b5d1fd2bde37aeb35288da13)
| source4/lib/talloc/talloc.c | diffblobblamehistory |