repo.or.cz
/
Samba.git
/
search
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
log
|
graphiclog1
|
graphiclog2
|
commit
|
commitdiff
|
tree
|
refs
|
edit
|
fork
first
·
prev
·
next
s4:dsdb: Fix comment
2023-09-14
Joseph Sutton
s4:dsdb
:
Fix comm
e
nt
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
Sutton
s3:winbindd: Add zero d
i
git
to li
t
eral
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
dsgetdcname
:
Remove excess zero
digits fr
o
m lit
e
r
als
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
fsrvp
.
idl: R
e
move
excess zero digit f
r
om li
t
er
a
l
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
S
utt
o
n
tes
t
s/k
r
b5: Rename ‘c
l
ient_claims’ to ‘claims_metada
t
a’
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Josep
h
Sutt
o
n
s
3
:
net:
Check
return value of d
a
ta
_
blob_talloc(
)
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jos
e
p
h
Sutton
s4:kdc: Don’t p
r
epend
u
s
e
less colon t
o
MIT K
D
C l
o
g
g
ing
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:wrepl_serv
e
r: Correctly
rea
d
‘type’ eleme
n
t
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
seph Sutton
ldb: P
r
e
fer explicit initi
a
l
i
zation
t
o
ZERO_ST
R
UCT()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
seph
Sutton
s4:kdc: R
e
move ks_is_tgs_princip
a
l()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph S
u
tton
testp
r
o
gs: Fix scrip
t
u
sage lines
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sut
t
o
n
s4:setup: Fix
script usage l
i
ne
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jo
s
e
p
h Sutton
s4:selft
e
st: Fix
s
cript usag
e
l
in
e
s
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jos
e
p
h
Sutton
s3:scr
i
pt: Fix script usage
l
ines
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
nsswitch: Fix scr
i
pt
usage
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
seph Sutt
o
n
lib:
k
rb5_
w
r
ap: Remove
Heimdal‐only krb5_princ_component
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
Sutton
s4:rpc_se
r
ver: Swit
c
h to using smb_krb5_p
r
i
n
c
_
compon
e
nt()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph S
u
tton
s4:kdc: Switch
t
o
u
s
i
n
g smb_krb5_p
r
inc_componen
t
()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:dsdb
:
S
w
itch t
o
using smb_krb5_pr
i
n
c_component()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jos
e
ph
Sutton
li
b
:krb5
_
wra
p
:
Add Heimdal‐specific smb_kr
b
5
_
princ_component
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
sep
h
S
utton
lib:krb5_wr
a
p: Add smb_krb
5
_princ_com
p
onen
t
()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
lib:krb5_wrap:
H
ave smb_krb
5
_principal_ge
t
_realm()
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
lib:krb5_wra
p
: Eliminate
r
e
d
undan
t
c
ode
f
rom
s
m
b
_kr
b
5_s
o
c
k
ad
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s
4:kdc: Fix
leaks
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
os
e
ph Sutton
s4:kdc: Be
sure not
to
pass a
NULL pointer into
s
tr
c
mp
(
)
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Josep
h
Su
t
ton
s
4:kdc: Prefer explicit initializat
i
on to ZERO_STRUCTP()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
oseph Su
t
ton
s4:kdc: Make R
O
DC ID checks e
a
s
i
er t
o
understand with
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jos
e
p
h
Sutton
s
4
:kdc: Rename
‘
status’ variables to ‘reply_status
’
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
S
u
t
ton
s4:kdc: Have
s
am
b
a_krbtgt_is_in_db() take a c
o
nst
KDC
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:kdc: Have samba_krbtg
t
_is_i
n
_db() return a krb5_error
_
co
d
e
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:kdc: M
a
ke pac_blo
b
s_remove_blob() never
fail
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jo
s
e
ph Sutton
s
4
:kdc: Make ‘struct pac_blobs’ memory handling safer
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:kdc: Don’t
c
orrupt
p
a
c_blobs struc
t
u
r
e if tal
l
oc_rea
l
loc
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
Sutton
s4:kd
c
: Add co
m
m
o
n out path to pac_blobs
_
f
rom_
k
rb5
_
pac()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
s
eph Sutton
s4
:
k
d
c: Introduce a tempo
r
ary tal
l
o
c context in sam
b
a_
k
dc_up
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph S
u
tton
s4:kdc
:
U
s
e t
e
m
porary m
e
mory
contex
t
in
samba_kdc_verify_pac()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph S
u
tton
s4:kd
c
: Fix le
a
k
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
S
utton
s4:kdc: A
l
locate varia
b
les on to
more
s
uitable
memory
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
S
utton
s4:kdc: Increment PAC_DEVICE
_
INFO::domain_grou
p
_count
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Josep
h
Sutt
o
n
s4:kdc: Directl
y
zer
o
‐initialize PAC_DOMAIN_GROUP_MEMBERSHI
P
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:kdc: Assign RID and attrib
u
te together
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
oseph Su
t
ton
s4:kdc
:
Don’t co
r
rupt do
m
a
i
n g
r
oups
s
t
r
ucture if talloc_re
a
l
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jo
s
eph Sut
t
on
s4:kdc: C
h
eck
for overflow
w
h
e
n ad
d
ing a d
o
ma
i
n
gr
o
up
S
I
D
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
seph Sutton
s4:kdc:
A
void potenti
a
l use‐after‐free
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:kdc:
Fi
x
leak
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:k
d
c: U
s
e
co
m
mo
n
e
x
it point for func
t
ions
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
s
e
ph Sutton
s
4:kdc: Fix lea
k
s
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:kdc:
A
dd cor
r
e
ct
A
s
s
erte
d
Ide
n
tity SID
in r
e
sponse
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
se
p
h Sutton
s4:auth: F
i
x leak
s
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
S
utto
n
s4:auth: Check return va
l
ue
s
of talloc
functi
o
ns
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
oseph Sutton
s4:dsdb: Pr
e
f
e
r explicit ini
t
ia
l
ization to ZERO_STRUCT()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jos
e
ph Sut
t
on
s4:dsdb
:
Parenthesize macro expression
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jo
s
eph Sutton
s4:scripting: Prefer
‘x not in y’ to ‘not x i
n
y
’
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:sc
r
ip
t
ing: Fix co
m
ments
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4
:
kdc: Inli
n
e samba_get_
p
a
c
_a
t
tr
s
_blob
(
)
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s3:r
p
c_serv
e
r: Fix inve
r
ted er
r
or messages
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
os
e
ph Sutto
n
py
t
h
on:te
s
ts: Fix in
v
alid e
s
c
a
pe sequence
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
S
utton
python:t
e
s
ts
:
Remo
v
e unused var
i
ables
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
d
ocs-xml
:
Add mis
s
ing
pa
r
agr
a
p
h sec
t
ion
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jo
s
eph Sutton
s4:
k
dc: Fix leaks
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
s
eph
Sutton
s4:kdc
:
Don’t operate directly on caller‐owne
d
po
i
nter
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:kdc: Alloca
t
e co
n
t
ents of PA
C
bl
o
bs on blob talloc
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jo
s
e
ph Su
t
ton
s4:kd
c
:
I
nl
i
ne samba_ge
t
_
r
e
quester_
s
i
d
_
pac_blob()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:kdc: Fix error mes
s
age
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
s
e
p
h
S
utton
s4:kdc:
Initialize pointers to NULL
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
s
eph Sutto
n
s4:k
d
c: Correct err
o
r m
e
ssage
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Josep
h
Sutton
s4:kdc: Check return value of smb_krb5_principal_ge
t
_c
o
mp
_
st
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
Sutton
s4:
k
dc: R
e
move unused
talloc conte
x
t
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jo
s
eph Sutton
s4:kdc: Che
c
k
r
eturn value of sa
m
db_result
_
do
m
_sid()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
c
l
aim
s
.
idl: Be more lenient in our exp
e
c
t
a
tions
f
o
r
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
cla
i
m
s
.
id
l
: Allow e
m
pty claim value buffers
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
Su
t
ton
s
4:kdc: Make functions to a
d
d special
S
IDs non‐st
a
tic
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jo
s
eph Sutt
o
n
s4:kdc: Check result of talloc_real
l
oc()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Josep
h
Sutton
s4:kdc: Handle inva
l
id enum values
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
o
s
e
p
h Sutton
s4
:
kdc: Check resu
l
t of dom_s
i
d_parse()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:kdc: Re
m
ove
unused fl
a
gs
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
s4:k
d
c: Use s
m
b_krb5_data_from_bl
o
b()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
J
os
e
ph Sutton
s
4:kdc:
R
emo
v
e du
p
licate
fun
c
tion signature
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph
Sutto
n
s4:kdc: Prefer exp
l
ici
t
i
nit
i
al
i
za
t
ion t
o
ZERO_S
T
R
UCT(
)
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
l
i
bcli:securi
t
y: Pref
e
r
e
x
p
l
icit initialization to
.
.
.
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jose
p
h
Sutton
s4:scripting: Remove unused
imports
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jose
p
h
Sut
t
on
python:tests: Re
m
ove unused impo
r
ts
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph Sutton
l
i
brpc:ndr: Avoid overflow in
size calculation
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jos
e
ph
Sutton
libgpo: Remove unne
c
essary c
a
st
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Jose
p
h Sutton
lib
:
tdr: Rem
o
v
e un
n
ecessary cast
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-14
Joseph S
u
t
t
o
n
lib:mscat
:
Remove unnecessary casts
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Samuel C
a
brero
auth:c
r
e
d
e
ntials
:
Check
i
f password_obt
a
ined
> obtained
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
...User(master): Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Samuel Cabre
r
o
netapi:
Pass net's cmdline
credential
s
t
o li
b
netapi_net_init()
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Samuel Cabrero
netapi: Pass loadparm
_
context to libn
e
tapi_
n
et_init(
)
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Dou
g
l
a
s Bagnall
s
3
:rpc: bump named_pipe_auth_
r
eq_info version numbe
r
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Andrew Bartlett
.
g
itlab-ci
.
yml: Move coverity buil
d
to internal
H
ei
m
d
al
Signed-off-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Jose
p
h Sut
t
on
s4:wre
p
l_se
r
ver: F
i
x code
spelling
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Joseph Su
t
ton
s4:
t
orture: Fi
x
code spelling
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Jose
p
h Sutton
s4
:
samba: Fix code sp
e
lling
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Joseph Sutton
s
4
:rpc_server: Fi
x
code spelling
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Jos
e
ph Sutton
s4:ntvfs:
Fi
x
c
o
de sp
e
lling
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
J
o
seph Sutton
s4:l
i
bn
e
t: Fix code s
p
ell
i
ng
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
J
o
seph Sutton
s4:libcli:
Fix code spelling
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Joseph
S
utton
s4:k
d
c: Fix c
o
de
s
pelling
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
2023-09-11
Josep
h
Su
t
ton
s
4
:dsdb:
F
i
x
code
spellin
g
Reviewed-by: Andrew Bartlett <
abartlet@samba.org
>
commit
|
commitdiff
|
tree
next