From f6a75cf4d18621e05206368b6811057450f65d75 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 7 Mar 2015 10:24:18 +0000 Subject: [PATCH] registry: Fix CID 240989 Buffer not null terminated This makes it clearer that we don't really have a string in .hdr Signed-off-by: Volker Lendecke Reviewed-by: Ira Cooper --- source4/lib/registry/patchfile_preg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/lib/registry/patchfile_preg.c b/source4/lib/registry/patchfile_preg.c index 28b56dd7e95..8017b5814f3 100644 --- a/source4/lib/registry/patchfile_preg.c +++ b/source4/lib/registry/patchfile_preg.c @@ -187,7 +187,7 @@ _PUBLIC_ WERROR reg_preg_diff_save(TALLOC_CTX *ctx, const char *filename, data->fd = STDOUT_FILENO; } - strncpy(preg_header.hdr, "PReg", 4); + memcpy(preg_header.hdr, "PReg", sizeof(preg_header.hdr)); SIVAL(&preg_header.version, 0, 1); write(data->fd, (uint8_t *)&preg_header, sizeof(preg_header)); -- 2.11.4.GIT