From f11a1a4a0796c8e77eee721f1ed1406b01e2b007 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Matthias=20Dieter=20Walln=C3=B6fer?= Date: Mon, 13 Aug 2012 20:17:20 +0200 Subject: [PATCH] s4:kdc/wdc-samba4.c - fix user logins on specific workstations The decrement operation has been missing. Problem found by Mohammad Ebrahim Abravi Signed-off-by: Andrew Bartlett --- source4/kdc/wdc-samba4.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/source4/kdc/wdc-samba4.c b/source4/kdc/wdc-samba4.c index 70e849ccb74..2f4945c312c 100644 --- a/source4/kdc/wdc-samba4.c +++ b/source4/kdc/wdc-samba4.c @@ -187,14 +187,15 @@ static char *get_netbios_name(TALLOC_CTX *mem_ctx, HostAddresses *addrs) } } - if (nb_name == NULL) { + if ((nb_name == NULL) || (nb_name[0] == '\0')) { return NULL; } /* Strip space padding */ - i = strlen(nb_name) - 1; - while (i > 0 && nb_name[i] == ' ') { - nb_name[i] = '\0'; + for (len = strlen(nb_name) - 1; + (len > 0) && (nb_name[len] == ' '); + --len) { + nb_name[len] = '\0'; } return nb_name; -- 2.11.4.GIT