From f05db5edc434da61bc7cd7233c5b9cb61cd888bf Mon Sep 17 00:00:00 2001 From: Martin Schwenke Date: Fri, 29 Nov 2013 14:05:49 +1100 Subject: [PATCH] ctdb/tests/integration: Update daemons shutdown pseudo-test Don't scatter the TEST_LOCAL_DAEMONS logic around the code. Limit it to the local daemons file. Signed-off-by: Martin Schwenke Reviewed-by: Michael Adam --- ctdb/tests/scripts/integration.bash | 6 ++++++ ctdb/tests/simple/99_daemons_shutdown.sh | 6 +++--- ctdb/tests/simple/scripts/local_daemons.bash | 7 +++++++ 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/ctdb/tests/scripts/integration.bash b/ctdb/tests/scripts/integration.bash index c13ee1f6027..4d22f4150fd 100644 --- a/ctdb/tests/scripts/integration.bash +++ b/ctdb/tests/scripts/integration.bash @@ -518,6 +518,12 @@ restart_ctdb () return 1 } +# Does nothing on cluster and should be overridden for local daemons +maybe_stop_ctdb () +{ + : +} + ctdb_restart_when_done () { ctdb_test_restart_scheduled=true diff --git a/ctdb/tests/simple/99_daemons_shutdown.sh b/ctdb/tests/simple/99_daemons_shutdown.sh index 3583828b71a..42ea1f4031c 100755 --- a/ctdb/tests/simple/99_daemons_shutdown.sh +++ b/ctdb/tests/simple/99_daemons_shutdown.sh @@ -18,6 +18,6 @@ EOF # Do not call ctdb_test_init() here. It will setup ctdb_test_exit() # to run and that will find the daemons missing and restart them! -if [ -n "$TEST_LOCAL_DAEMONS" ] && $TEST_CLEANUP ; then - daemons_stop -fi +# We only want to consider stopping CTDB if we're running local +# daemons. This function will do the right thing. +maybe_stop_ctdb diff --git a/ctdb/tests/simple/scripts/local_daemons.bash b/ctdb/tests/simple/scripts/local_daemons.bash index b286b4d5b5c..6bd2138a828 100644 --- a/ctdb/tests/simple/scripts/local_daemons.bash +++ b/ctdb/tests/simple/scripts/local_daemons.bash @@ -120,3 +120,10 @@ daemons_start () daemons_start_1 $i "$@" done } + +maybe_stop_ctdb () +{ + if $TEST_CLEANUP ; then + daemons_stop + fi +} -- 2.11.4.GIT