From df9a97b81f2a5520ed0ef79d9aeb3a014799e89c Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Wed, 1 Feb 2012 13:21:04 +0100 Subject: [PATCH] s3-spoolss: remove duplicate "." in smbd spooler path --- source3/printing/printspoolss.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/source3/printing/printspoolss.c b/source3/printing/printspoolss.c index 3d8b0d8b1bb..23464d59b0b 100644 --- a/source3/printing/printspoolss.c +++ b/source3/printing/printspoolss.c @@ -82,7 +82,8 @@ NTSTATUS print_spool_open(files_struct *fsp, } } - /* Ok, now we have to open an actual file. + /* + * Ok, now we have to open an actual file. * Here is the reason: * We want to write the spool job to this file in * smbd for scalability reason (and also because @@ -92,9 +93,13 @@ NTSTATUS print_spool_open(files_struct *fsp, * to spoolss in output_file so it can monitor and * take over once we call EndDocPrinter(). * Of course we will not start writing until - * StartDocPrinter() actually gives the ok. */ + * StartDocPrinter() actually gives the ok. + * smbd spooler files do not include a print jobid + * path component, as the jobid is only known after + * calling StartDocPrinter(). + */ - pf->filename = talloc_asprintf(pf, "%s/%s.XXXXXX", + pf->filename = talloc_asprintf(pf, "%s/%sXXXXXX", lp_pathname(SNUM(fsp->conn)), PRINT_SPOOL_PREFIX); if (!pf->filename) { -- 2.11.4.GIT