From d8acbe73d93d02887583c0f8d7c4dbff1638520a Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Thu, 31 May 2018 20:57:36 +0200 Subject: [PATCH] dns: Simplify logic a bit We don't need a separate boolean variable Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider --- source4/dns_server/dns_crypto.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/source4/dns_server/dns_crypto.c b/source4/dns_server/dns_crypto.c index c8b5c46ad30..740e1e4dd53 100644 --- a/source4/dns_server/dns_crypto.c +++ b/source4/dns_server/dns_crypto.c @@ -100,7 +100,6 @@ WERROR dns_verify_tsig(struct dns_server *dns, WERROR werror; NTSTATUS status; enum ndr_err_code ndr_err; - bool found_tsig = false; uint16_t i, arcount = 0; DATA_BLOB tsig_blob, fake_tsig_blob, sig; uint8_t *buffer = NULL; @@ -113,12 +112,12 @@ WERROR dns_verify_tsig(struct dns_server *dns, /* Find the first TSIG record in the additional records */ for (i=0; i < packet->arcount; i++) { if (packet->additional[i].rr_type == DNS_QTYPE_TSIG) { - found_tsig = true; break; } } - if (!found_tsig) { + if (i == packet->arcount) { + /* no TSIG around */ return WERR_OK; } -- 2.11.4.GIT