From d5c0ad63c942f4df60ef6dfcee5c48c65ba7dea3 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 10 Jan 2018 14:59:08 +0100 Subject: [PATCH] smbd: Remove a "!" from an if-condition for easier readability Bug: https://bugzilla.samba.org/show_bug.cgi?id=13215 Signed-off-by: Volker Lendecke Reviewed-by: Stefan Metzmacher (cherry picked from commit 03f65a7cdc91091a171269cfebc9916f2f678388) --- source3/smbd/smb2_server.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c index 565f9996245..69788e9b2f5 100644 --- a/source3/smbd/smb2_server.c +++ b/source3/smbd/smb2_server.c @@ -2231,11 +2231,11 @@ static NTSTATUS smbd_smb2_request_dispatch_update_counts( cmp *= -1; } - if (!(flags & SMB2_HDR_FLAG_REPLAY_OPERATION)) { - if (cmp == 0) { + if (flags & SMB2_HDR_FLAG_REPLAY_OPERATION) { + if (cmp == 0 && op->pre_request_count == 0) { op->request_count += 1; req->request_counters_updated = true; - } else if (cmp > 0) { + } else if (cmp > 0 && op->pre_request_count == 0) { op->pre_request_count += op->request_count; op->request_count = 1; op->global->channel_sequence = channel_sequence; @@ -2245,10 +2245,10 @@ static NTSTATUS smbd_smb2_request_dispatch_update_counts( return NT_STATUS_FILE_NOT_AVAILABLE; } } else { - if (cmp == 0 && op->pre_request_count == 0) { + if (cmp == 0) { op->request_count += 1; req->request_counters_updated = true; - } else if (cmp > 0 && op->pre_request_count == 0) { + } else if (cmp > 0) { op->pre_request_count += op->request_count; op->request_count = 1; op->global->channel_sequence = channel_sequence; -- 2.11.4.GIT