From cf73692f96d0ab7d2722695d02e4eceb1358574b Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Fri, 28 Feb 2014 16:57:23 +0100 Subject: [PATCH] s3-auth: Make is_null_sid() check easier to read. Signed-off-by: Simo Sorce Reviewed-by: Andreas Schneider Reviewed-by: Guenther Deschner --- source3/auth/server_info.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/source3/auth/server_info.c b/source3/auth/server_info.c index 43711d5bc0e..c363f444d90 100644 --- a/source3/auth/server_info.c +++ b/source3/auth/server_info.c @@ -453,6 +453,7 @@ NTSTATUS passwd_to_SamInfo3(TALLOC_CTX *mem_ctx, enum lsa_SidType type; uint32_t num_sids = 0; struct dom_sid *user_sids = NULL; + bool is_null; bool ok; tmp_ctx = talloc_stackframe(); @@ -514,8 +515,8 @@ NTSTATUS passwd_to_SamInfo3(TALLOC_CTX *mem_ctx, } /* Make sure we have a valid group sid */ - ok = !is_null_sid(&group_sid); - if (!ok) { + is_null = is_null_sid(&group_sid); + if (is_null) { status = NT_STATUS_NO_SUCH_USER; goto done; } -- 2.11.4.GIT