From c9e6331afc1ee0e85a9582c6682ff95885135792 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Fri, 12 Apr 2019 15:10:35 +1200 Subject: [PATCH] ndrdump: change behaviour of flags to operate as flags These are called flags because that is what they become to the ndr_pull function, but to avoid total confusion treat them as flags generally even if the values are always exclusive (at the moment). Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall --- librpc/tools/ndrdump.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/librpc/tools/ndrdump.c b/librpc/tools/ndrdump.c index b7eae70833e..ef7f9c66139 100644 --- a/librpc/tools/ndrdump.c +++ b/librpc/tools/ndrdump.c @@ -201,7 +201,7 @@ static void ndr_print_dummy(struct ndr_print *ndr, const char *format, ...) struct ndr_pull *ndr_pull; struct ndr_print *ndr_print; TALLOC_CTX *mem_ctx; - int flags; + int flags = 0; poptContext pc; NTSTATUS status; enum ndr_err_code ndr_err; @@ -316,10 +316,10 @@ static void ndr_print_dummy(struct ndr_print *ndr, const char *format, ...) if (strcmp(inout, "in") == 0 || strcmp(inout, "request") == 0) { - flags = NDR_IN; + flags |= NDR_IN; } else if (strcmp(inout, "out") == 0 || strcmp(inout, "response") == 0) { - flags = NDR_OUT; + flags |= NDR_OUT; } else { printf("Bad inout value '%s'\n", inout); exit(1); @@ -340,7 +340,7 @@ static void ndr_print_dummy(struct ndr_print *ndr, const char *format, ...) } if (ctx_filename) { - if (flags == NDR_IN) { + if (flags & NDR_IN) { printf("Context file can only be used for \"out\" packages\n"); exit(1); } -- 2.11.4.GIT