From c27c97ab552d18de00ec4eb9cbc4da457daa15a6 Mon Sep 17 00:00:00 2001 From: David Mulder Date: Tue, 9 Feb 2021 11:06:40 -0700 Subject: [PATCH] gpo: Test that empty Security sections are removed Ensure that empty sections are removed when calling samba-tool gpo manage security set. Signed-off-by: David Mulder Reviewed-by: Jeremy Allison --- python/samba/tests/samba_tool/gpo.py | 35 +++++++++++++++++++++++++++++++++++ selftest/knownfail.d/gpo | 1 + 2 files changed, 36 insertions(+) create mode 100644 selftest/knownfail.d/gpo diff --git a/python/samba/tests/samba_tool/gpo.py b/python/samba/tests/samba_tool/gpo.py index d678a96352b..588c63a703c 100644 --- a/python/samba/tests/samba_tool/gpo.py +++ b/python/samba/tests/samba_tool/gpo.py @@ -692,6 +692,41 @@ class GpoCmdTestCase(SambaToolCmdTest): self.assertCmdSuccess(result, out, err, 'Failed to unset MaxTicketAge') + def test_security_nonempty_sections(self): + lp = LoadParm() + lp.load(os.environ['SERVERCONFFILE']) + local_path = lp.get('path', 'sysvol') + gpt_inf = os.path.join(local_path, lp.get('realm').lower(), 'Policies', + self.gpo_guid, 'Machine/Microsoft/Windows NT', + 'SecEdit/GptTmpl.inf') + + (result, out, err) = self.runsublevelcmd("gpo", ("manage", "security", + "set"), self.gpo_guid, + 'MaxTicketAge', '10', + "-H", "ldap://%s" % + os.environ["SERVER"], + "-U%s%%%s" % + (os.environ["USERNAME"], + os.environ["PASSWORD"])) + self.assertCmdSuccess(result, out, err, + 'Failed to set MaxTicketAge') + + (result, out, err) = self.runsublevelcmd("gpo", ("manage", "security", + "set"), self.gpo_guid, + 'MaxTicketAge', + "-H", "ldap://%s" % + os.environ["SERVER"], + "-U%s%%%s" % + (os.environ["USERNAME"], + os.environ["PASSWORD"])) + self.assertCmdSuccess(result, out, err, + 'Failed to unset MaxTicketAge') + + inf_data = ConfigParser(interpolation=None) + inf_data.read(gpt_inf) + + self.assertFalse(inf_data.has_section('Kerberos Policy')) + def test_sudoers_remove(self): lp = LoadParm() lp.load(os.environ['SERVERCONFFILE']) diff --git a/selftest/knownfail.d/gpo b/selftest/knownfail.d/gpo new file mode 100644 index 00000000000..f01f38d75a2 --- /dev/null +++ b/selftest/knownfail.d/gpo @@ -0,0 +1 @@ +^samba.tests.samba_tool.gpo.samba.tests.samba_tool.gpo.GpoCmdTestCase.test_security_nonempty_sections -- 2.11.4.GIT