From b2e427b48c46e589b2f14da3bb0fc8032d482858 Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn@samba.org>
Date: Thu, 7 Dec 2023 13:11:46 +0100
Subject: [PATCH] s3:tests: Remove the non-working test_kerberos_upn_denied of
 smbget

See TODO code comment for details.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15532

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 1a04fd255c2c94e01bda9840bfd6b372007bb3c7)
---
 source3/script/tests/test_smbget.sh | 52 +++++++++++++++++++++----------------
 1 file changed, 30 insertions(+), 22 deletions(-)

diff --git a/source3/script/tests/test_smbget.sh b/source3/script/tests/test_smbget.sh
index 50e8cea3900..1956fc5b38e 100755
--- a/source3/script/tests/test_smbget.sh
+++ b/source3/script/tests/test_smbget.sh
@@ -480,26 +480,34 @@ test_kerberos_trust()
 	return 0
 }
 
-test_kerberos_upn_denied()
-{
-	clear_download_area
-
-	$SMBGET --verbose --use-kerberos=required \
-		-U"testdenied_upn@${REALM}.upn%${PASSWORD}" \
-		"smb://${SERVER}/smbget/testfile"
-	if [ $? -ne 0 ]; then
-		echo 'ERROR: RC does not match, expected: 0'
-		return 1
-	fi
-
-	cmp --silent $WORKDIR/testfile ./testfile
-	if [ $? -ne 0 ]; then
-		echo 'ERROR: file content does not match'
-		return 1
-	fi
-
-	return 0
-}
+# TODO FIXME
+# This test does not work, as we can't tell the libsmb code that the
+# principal is an enterprice principal. We need support for enterprise
+# principals in kerberos_kinit_password_ext() and a way to pass it via the
+# credenitals structure and commandline options.
+# It works if you do: kinit -E testdenied_upn@${REALM}.upn
+#
+# test_kerberos_upn_denied()
+# {
+# 	set -x
+# 	clear_download_area
+#
+# 	$SMBGET --verbose --use-kerberos=required \
+# 		-U"testdenied_upn@${REALM}.upn%${DC_PASSWORD}" \
+# 		"smb://${SERVER}.${REALM}/smbget/testfile" -d10
+# 	if [ $? -ne 0 ]; then
+# 		echo 'ERROR: RC does not match, expected: 0'
+# 		return 1
+# 	fi
+#
+# 	cmp --silent $WORKDIR/testfile ./testfile
+# 	if [ $? -ne 0 ]; then
+# 		echo 'ERROR: file content does not match'
+# 		return 1
+# 	fi
+#
+# 	return 0
+# }
 
 create_test_data
 
@@ -567,8 +575,8 @@ testit "kerberos" test_kerberos ||
 testit "kerberos_trust" test_kerberos_trust ||
 	failed=$((failed + 1))
 
-testit "kerberos_upn_denied" test_kerberos_upn_denied ||
-	failed=$((failed + 1))
+# testit "kerberos_upn_denied" test_kerberos_upn_denied ||
+# 	failed=$((failed + 1))
 
 clear_download_area
 
-- 
2.11.4.GIT