From b1cbf46f992ab6dc48996cf7e7e7740198d04452 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 2 Aug 2011 20:49:46 +0200 Subject: [PATCH] Fix bug 7462 - Non-standard SA_RESETHAND is used in ...lib/tevent/tevent_sig Make SA_RESETHAND conditional on its existance. Autobuild-User: Jeremy Allison Autobuild-Date: Mon Aug 1 22:03:45 CEST 2011 on sn-devel-104 (cherry picked from commit 0c67efdd68b9808542c090b9fd9920e4e37d85d0) (cherry picked from commit 490986add9d5e80b24e90dbfe3e3ef23ce5584a0) --- lib/replace/system/wait.h | 4 ---- lib/tevent/testsuite.c | 2 ++ lib/tevent/tevent_signal.c | 4 ++++ 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/replace/system/wait.h b/lib/replace/system/wait.h index 79583ad2abc..497f5597a72 100644 --- a/lib/replace/system/wait.h +++ b/lib/replace/system/wait.h @@ -44,10 +44,6 @@ #include #endif -#ifndef SA_RESETHAND -#define SA_RESETHAND SA_ONESHOT -#endif - #if !defined(HAVE_SIG_ATOMIC_T_TYPE) typedef int sig_atomic_t; #endif diff --git a/lib/tevent/testsuite.c b/lib/tevent/testsuite.c index f9aca91aa1c..41f73457216 100644 --- a/lib/tevent/testsuite.c +++ b/lib/tevent/testsuite.c @@ -101,7 +101,9 @@ static bool test_event_context(struct torture_context *test, #ifdef SA_RESTART se1 = event_add_signal(ev_ctx, ev_ctx, SIGALRM, SA_RESTART, count_handler, &alarm_count); #endif +#ifdef SA_RESETHAND se2 = event_add_signal(ev_ctx, ev_ctx, SIGALRM, SA_RESETHAND, count_handler, &alarm_count); +#endif #ifdef SA_SIGINFO se3 = event_add_signal(ev_ctx, ev_ctx, SIGUSR1, SA_SIGINFO, count_handler, &info_count); #endif diff --git a/lib/tevent/tevent_signal.c b/lib/tevent/tevent_signal.c index 45f65cf6ddd..2e9f20a6715 100644 --- a/lib/tevent/tevent_signal.c +++ b/lib/tevent/tevent_signal.c @@ -355,16 +355,20 @@ int tevent_common_check_signal(struct tevent_context *ev) (void*)&sig_state->sig_info[i][ofs], se->private_data); } +#ifdef SA_RESETHAND if (se->sa_flags & SA_RESETHAND) { talloc_free(se); } +#endif continue; } #endif se->handler(ev, se, i, count, NULL, se->private_data); +#ifdef SA_RESETHAND if (se->sa_flags & SA_RESETHAND) { talloc_free(se); } +#endif } #ifdef SA_SIGINFO -- 2.11.4.GIT