From b120493a2c0c6c321d95546e13e6e1c4d44b40bb Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 31 Aug 2008 11:34:01 +0200 Subject: [PATCH] Fix Coverity ID 592 The scanner did not figure out that we always have a primary domain, so it complained about us potentially passing a NULL pointer down to set_domain_online_request() where it is dereferenced. Make the code a bit clearer. (cherry picked from commit e6e8d108f95ed974f98f3f57adcfbbde4e00fad9) (cherry picked from commit 70dbc13aaef893b25e3164fdcf187a01ec27b392) --- source/winbindd/winbindd_dual.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source/winbindd/winbindd_dual.c b/source/winbindd/winbindd_dual.c index 1e8325f9833..f3b277cc84e 100644 --- a/source/winbindd/winbindd_dual.c +++ b/source/winbindd/winbindd_dual.c @@ -1107,6 +1107,10 @@ static bool fork_domain_child(struct winbindd_child *child) } } + if (primary_domain == NULL) { + smb_panic("no primary domain found"); + } + /* Ensure we're not handling an event inherited from our parent. */ -- 2.11.4.GIT