From b066dba462f95eedbdd5e7d7d5edb5acaf1ec051 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Mon, 7 Feb 2022 10:11:36 +0100 Subject: [PATCH] ndrdump: Small simplification Remove the talloc_steal(), we can allocate on mem_ctx directly Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- librpc/tools/ndrdump.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/librpc/tools/ndrdump.c b/librpc/tools/ndrdump.c index b5d7f4fa3f6..0d39ed3714b 100644 --- a/librpc/tools/ndrdump.c +++ b/librpc/tools/ndrdump.c @@ -553,10 +553,9 @@ static void ndr_print_dummy(struct ndr_print *ndr, const char *format, ...) blob = hexdump_to_data_blob(mem_ctx, (const char *)data, size); } else if (base64_input) { /* Use talloc_strndup() to ensure null termination */ - blob = base64_decode_data_blob(talloc_strndup(mem_ctx, - (const char *)data, size)); - /* base64_decode_data_blob() allocates on NULL */ - talloc_steal(mem_ctx, blob.data); + blob = base64_decode_data_blob_talloc( + mem_ctx, + talloc_strndup(mem_ctx, (const char *)data, size)); } else { blob = data_blob_const(data, size); } -- 2.11.4.GIT