From a81818ae54159755df441cc6421e5b272035f412 Mon Sep 17 00:00:00 2001 From: =?utf8?q?G=C3=BCnther=20Deschner?= Date: Wed, 7 May 2008 14:09:41 +0200 Subject: [PATCH] dsgetdcname: remove invalid assumptions when using DNS for the DC query. Guenther --- source/libsmb/dsgetdcname.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/source/libsmb/dsgetdcname.c b/source/libsmb/dsgetdcname.c index 1bd54d80e6e..1006b975c74 100644 --- a/source/libsmb/dsgetdcname.c +++ b/source/libsmb/dsgetdcname.c @@ -466,14 +466,6 @@ static NTSTATUS discover_dc_dns(TALLOC_CTX *mem_ctx, struct ip_service_name *dclist = NULL; int count = 0; - if ((!(flags & DS_DIRECTORY_SERVICE_REQUIRED)) && - (!(flags & DS_KDC_REQUIRED)) && - (!(flags & DS_GC_SERVER_REQUIRED)) && - (!(flags & DS_PDC_REQUIRED))) { - DEBUG(1,("discover_dc_dns: invalid flags\n")); - return NT_STATUS_INVALID_PARAMETER; - } - if (flags & DS_PDC_REQUIRED) { status = ads_dns_query_pdc(mem_ctx, domain_name, &dcs, &numdcs); @@ -490,9 +482,8 @@ static NTSTATUS discover_dc_dns(TALLOC_CTX *mem_ctx, status = ads_dns_query_dcs_guid(mem_ctx, domain_name, domain_guid, &dcs, &numdcs); } else { - /* FIXME: ? */ - DEBUG(1,("discover_dc_dns: not enough input\n")); - status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND; + status = ads_dns_query_dcs(mem_ctx, domain_name, site_name, + &dcs, &numdcs); } if (!NT_STATUS_IS_OK(status)) { -- 2.11.4.GIT