From a017280ca554a534d9422a055b1cfc0baa3eb8c6 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 22 Jul 2014 10:34:08 +0000 Subject: [PATCH] messaging4: Fix a just-introduced error memleak Signed-off-by: Volker Lendecke Reviewed-by: Stefan Metzmacher Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Tue Jul 22 15:31:38 CEST 2014 on sn-devel-104 --- source4/lib/messaging/messaging.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/source4/lib/messaging/messaging.c b/source4/lib/messaging/messaging.c index 137d859f2bf..4242b1cc856 100644 --- a/source4/lib/messaging/messaging.c +++ b/source4/lib/messaging/messaging.c @@ -969,6 +969,11 @@ NTSTATUS irpc_servers_byname(struct imessaging_context *msg_ctx, count = rec.dsize / sizeof(struct server_id); if (count == 0) { + /* + * In a corrupted db we could end up with a record of size + * less than a struct server_id. Don't leak in this case. + */ + free(rec.dptr); return NT_STATUS_NOT_FOUND; } -- 2.11.4.GIT