From 9f3b0295fe7bd6c0c3a6061e5d00e7b88f702b21 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Mon, 8 Mar 2004 09:52:17 +0000 Subject: [PATCH] 2 fixes to enhance readability of source code and debug messages 1 fix for a memleak --- source/lib/privileges.c | 2 +- source/passdb/passdb.c | 2 ++ source/smbd/sec_ctx.c | 6 +++--- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/source/lib/privileges.c b/source/lib/privileges.c index 4bcf5e3b36b..a3b85372c7f 100644 --- a/source/lib/privileges.c +++ b/source/lib/privileges.c @@ -372,7 +372,7 @@ NTSTATUS dup_priv_set(PRIVILEGE_SET *new_priv_set, PRIVILEGE_SET *priv_set) LUID_ATTR *old_set; int i; - if (!new_priv_set || !priv_set) + if (new_priv_set == NULL || priv_set == NULL) return NT_STATUS_INVALID_PARAMETER; /* special case if there are no privileges in the list */ diff --git a/source/passdb/passdb.c b/source/passdb/passdb.c index 7c9376e045a..273428dacf1 100644 --- a/source/passdb/passdb.c +++ b/source/passdb/passdb.c @@ -1892,6 +1892,8 @@ BOOL init_sam_from_buffer_v1(SAM_ACCOUNT *sampass, uint8 *buf, uint32 buflen) done: + SAFE_FREE(lm_pw_ptr); + SAFE_FREE(nt_pw_ptr); SAFE_FREE(username); SAFE_FREE(domain); SAFE_FREE(nt_username); diff --git a/source/smbd/sec_ctx.c b/source/smbd/sec_ctx.c index 9244f34394e..97fe2dfaee1 100644 --- a/source/smbd/sec_ctx.c +++ b/source/smbd/sec_ctx.c @@ -258,7 +258,7 @@ BOOL push_sec_ctx(void) ctx_p->token = dup_nt_token(sec_ctx_stack[sec_ctx_stack_ndx-1].token); if (! ctx_p->token) { - DEBUG(0, ("Out of memory in push_sec_ctx()\n")); + DEBUG(0, ("Out of memory on dup_nt_token() in push_sec_ctx()\n")); return False; } @@ -266,7 +266,7 @@ BOOL push_sec_ctx(void) if (ctx_p->ngroups != 0) { if (!(ctx_p->groups = malloc(ctx_p->ngroups * sizeof(gid_t)))) { - DEBUG(0, ("Out of memory in push_sec_ctx()\n")); + DEBUG(0, ("Out of memory on malloc() in push_sec_ctx()\n")); delete_nt_token(&ctx_p->token); return False; } @@ -278,7 +278,7 @@ BOOL push_sec_ctx(void) init_privilege(&ctx_p->privs); if (! NT_STATUS_IS_OK(dup_priv_set(ctx_p->privs, sec_ctx_stack[sec_ctx_stack_ndx-1].privs))) { - DEBUG(0, ("Out of memory in push_sec_ctx()\n")); + DEBUG(0, ("Out of memory on dup_priv_set() in push_sec_ctx()\n")); delete_nt_token(&ctx_p->token); destroy_privilege(&ctx_p->privs); return False; -- 2.11.4.GIT