From 9eccf6a16f5b198181a4fa80b835b1a65b40ed76 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Tue, 14 Aug 2018 18:55:33 +0200 Subject: [PATCH] s3:libads: Free addr before we free the context Introduced by dbdbd4875ecac3e7334750f46f1f494b7afe6628 CID 1438395 BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567 Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Tue Aug 14 22:02:06 CEST 2018 on sn-devel-144 --- source3/libads/krb5_setpw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/libads/krb5_setpw.c b/source3/libads/krb5_setpw.c index 0418fec5ad3..8f9098853b9 100644 --- a/source3/libads/krb5_setpw.c +++ b/source3/libads/krb5_setpw.c @@ -222,9 +222,9 @@ static ADS_STATUS ads_krb5_chg_password(const char *kdc_host, /* We have to obtain an INITIAL changepw ticket for changing password */ if (asprintf(&chpw_princ, "kadmin/changepw@%s", realm) == -1) { krb5_get_init_creds_opt_free(context, opts); + smb_krb5_free_addresses(context, addr); krb5_free_context(context); free(realm); - smb_krb5_free_addresses(context, addr); DEBUG(1,("ads_krb5_chg_password: asprintf fail\n")); return ADS_ERROR_NT(NT_STATUS_NO_MEMORY); } -- 2.11.4.GIT