From 9554f39b1245408e19bba4bda83f280020a49657 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 31 Aug 2008 12:15:35 +0200 Subject: [PATCH] Fix Coverity ID 589, dead code (This used to be commit 67c0835226e189deba5856710a1dea19ac5f30fd) --- source3/nsswitch/libwbclient/wbc_sid.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/source3/nsswitch/libwbclient/wbc_sid.c b/source3/nsswitch/libwbclient/wbc_sid.c index 324a19bd564..f4ffa4e5caa 100644 --- a/source3/nsswitch/libwbclient/wbc_sid.c +++ b/source3/nsswitch/libwbclient/wbc_sid.c @@ -294,9 +294,18 @@ wbcErr wbcLookupSid(const struct wbcDomainSid *sid, } } else { +#if 0 + /* + * Found by Coverity: In this particular routine we can't end + * up here with a non-NULL name. Further up there are just two + * exit paths that lead here, neither of which leave an + * allocated name. If you add more paths up there, re-activate + * this. + */ if (name != NULL) { talloc_free(name); } +#endif if (domain != NULL) { talloc_free(domain); } -- 2.11.4.GIT